Convert CopyStat regression tests to Python suite
Recent Commits to brotli:master
-
Convert CopyStat regression tests to Python suite
-
Fix CopyStat TOCTOU in brotli CLI by using fd-based syscalls
Fix CopyStat TOCTOU in brotli CLI by using fd-based syscalls CloseFiles() previously called fclose(context->fout) before invoking CopyStat() on the output pathname. CopyStat() then used path-based chmod() and chown(), which gave an attacker with write access to the output directory a window to replace the path with a symlink between the close and the metadata syscalls, redirecting the chmod/chown to an arbitrary target. Close the race by doing the metadata copy while the output file is still open and by switching to fd-based syscalls on fileno(fout): - CopyStat() now takes FILE* fout and calls fchmod()/fchown() on the underlying fd. - CopyTimeStat() uses futimens(fd, ...) in the HAVE_UTIMENSAT branch; the legacy utime() fallback is preserved for platforms without it. - CloseFiles() invokes CopyStat() before fclose() and skips it when current_output_path is NULL (stdout), matching the issue's guidance. - Windows no-op shims updated from chmod/chown to fchmod/fchown. Adds deterministic regression coverage under tests/regression/t01/: an LD_PRELOAD fclose() swap reproduces the pre-fix behavior, and a negative-assertion wrapper confirms the attack no longer succeeds after the patch. Additional scripts cover mode/timestamp propagation, the -n (no-copy-stat) flag, stdin input, stdout output, mode mask, and roundtrip correctness. Refs google/brotli#1461
-
Bump actions/setup-node from 6.3.0 to 6.4.0
Bump actions/setup-node from 6.3.0 to 6.4.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/53b83947a5a98c8d113130e565377fae1a50d02f...48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Merge pull request #1458 from rbri:java_code_cleanup
Merge pull request #1458 from rbri:java_code_cleanup PiperOrigin-RevId: 900612609
-
use try-with-resources
use try-with-resources
-
Merge pull request #1453 from 0xazanul:fix/cli-comment-verification-r…
Merge pull request #1453 from 0xazanul:fix/cli-comment-verification-return PiperOrigin-RevId: 900007299
-
Merge branch 'master' into fix/cli-comment-verification-return
Merge branch 'master' into fix/cli-comment-verification-return
-
Merge pull request #1457 from google:dependabot/github_actions/action…
Merge pull request #1457 from google:dependabot/github_actions/actions/cache-5.0.5 PiperOrigin-RevId: 899533563
-
Merge branch 'master' into fix/cli-comment-verification-return
Merge branch 'master' into fix/cli-comment-verification-return
-
Bump actions/cache from 5.0.4 to 5.0.5 (#1457)
Bump actions/cache from 5.0.4 to 5.0.5 (#1457) Bumps [actions/cache](https://github.com/actions/cache) from 5.0.4 to 5.0.5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/668228422ae6a00e4ad889ee87cd7109ec5666a7...27d5ce7f107fe9357f9df03efb73ab90386fccae) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Merge branch 'master' into dependabot/github_actions/actions/cache-5.0.5
Merge branch 'master' into dependabot/github_actions/actions/cache-5.0.5
-
Bump mymindstorm/setup-emsdk from 15 to 16 (#1456)
Bump mymindstorm/setup-emsdk from 15 to 16 (#1456) Bumps [mymindstorm/setup-emsdk](https://github.com/mymindstorm/setup-emsdk) from 15 to 16. - [Release notes](https://github.com/mymindstorm/setup-emsdk/releases) - [Commits](https://github.com/mymindstorm/setup-emsdk/compare/667eb33f24e84e7f362c16d8d7fff0629a73e15e...4528d102f7230f0e7b276855c01ea1159be0e984) --- updated-dependencies: - dependency-name: mymindstorm/setup-emsdk dependency-version: '16' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Bump actions/cache from 5.0.4 to 5.0.5
Bump actions/cache from 5.0.4 to 5.0.5 Bumps [actions/cache](https://github.com/actions/cache) from 5.0.4 to 5.0.5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/668228422ae6a00e4ad889ee87cd7109ec5666a7...27d5ce7f107fe9357f9df03efb73ab90386fccae) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Bump step-security/harden-runner from 2.16.1 to 2.17.0 (#1455)
Bump step-security/harden-runner from 2.16.1 to 2.17.0 (#1455) Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.16.1 to 2.17.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](https://github.com/step-security/harden-runner/compare/fe104658747b27e96e4f7e80cd0a94068e53901d...f808768d1510423e83855289c910610ca9b43176) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.17.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Merge pull request #1444 from robinwatts:master
Merge pull request #1444 from robinwatts:master PiperOrigin-RevId: 899489367
-
Bump actions/upload-artifact from 7.0.0 to 7.0.1 (#1454)
Bump actions/upload-artifact from 7.0.0 to 7.0.1 (#1454) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/bbbca2ddaa5d8feaa63e36b76fdaad77386f024f...043fb46d1a93c77aae656e7c1c64a875d1fc6a0a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Merge branch 'master' into fix/cli-comment-verification-return
Merge branch 'master' into fix/cli-comment-verification-return
-
Merge branch 'master' into master
Merge branch 'master' into master
-
Merge pull request #1440 from google:dependabot/github_actions/github…
Merge pull request #1440 from google:dependabot/github_actions/github/codeql-action-4.35.1 PiperOrigin-RevId: 898835966
-
Merge branch 'master' into master
Merge branch 'master' into master
-
Bump github/codeql-action from 4.31.7 to 4.35.1 (#1440)
Bump github/codeql-action from 4.31.7 to 4.35.1 (#1440) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.7 to 4.35.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/cf1bb45a277cb3c205638b2cd5c984db1c46a412...c10b8064de6f491fea524254123dbe5e09572f13) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.35.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Merge branch 'master' into dependabot/github_actions/github/codeql-ac…
Merge branch 'master' into dependabot/github_actions/github/codeql-action-4.35.1
-
Bump github/codeql-action from 4.31.7 to 4.35.1
Bump github/codeql-action from 4.31.7 to 4.35.1 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.7 to 4.35.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/cf1bb45a277cb3c205638b2cd5c984db1c46a412...c10b8064de6f491fea524254123dbe5e09572f13) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.35.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Bump actions/download-artifact from 6.0.0 to 8.0.1 (#1441)
Bump actions/download-artifact from 6.0.0 to 8.0.1 (#1441) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6.0.0 to 8.0.1. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/018cc2cf5baa6db3ef3c5f8a56943fffe632ef53...3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Bump actions/setup-python from 6.1.0 to 6.2.0 (#1442)
Bump actions/setup-python from 6.1.0 to 6.2.0 (#1442) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.1.0 to 6.2.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](https://github.com/actions/setup-python/compare/83679a892e2d95755f2dac6acb0bfd1e9ac5d548...a309ff8b426b58ec0e2a45f0f869d46889d02405) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Bump step-security/harden-runner from 2.16.0 to 2.16.1 (#1445)
Bump step-security/harden-runner from 2.16.0 to 2.16.1 (#1445) Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.16.0 to 2.16.1. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](https://github.com/step-security/harden-runner/compare/fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594...fe104658747b27e96e4f7e80cd0a94068e53901d) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.16.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Bump mymindstorm/setup-emsdk from 14 to 15 (#1446)
Bump mymindstorm/setup-emsdk from 14 to 15 (#1446) Bumps [mymindstorm/setup-emsdk](https://github.com/mymindstorm/setup-emsdk) from 14 to 15. - [Release notes](https://github.com/mymindstorm/setup-emsdk/releases) - [Commits](https://github.com/mymindstorm/setup-emsdk/compare/6ab9eb1bda2574c4ddb79809fc9247783eaf9021...667eb33f24e84e7f362c16d8d7fff0629a73e15e) --- updated-dependencies: - dependency-name: mymindstorm/setup-emsdk dependency-version: '15' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Kliuchnikov <eustas.ru@gmail.com>
-
Make all BrotliOutputStream methods exclusive/blocking.
Make all BrotliOutputStream methods exclusive/blocking. If access is naturally exclusive, then it is nearly zero-cost (1 atomic CAS) PiperOrigin-RevId: 896977751
-
Check that total compound dictionary size does not overflow.
Check that total compound dictionary size does not overflow. Thanks to @0xazanul who reported the problem in #1438 PiperOrigin-RevId: 896638456
-
Fix partial javadocs
Fix partial javadocs PiperOrigin-RevId: 896503460
-
Fix compilation in ISO C enviroments; declare vars before code.
Fix compilation in ISO C enviroments; declare vars before code.