growlingbass: fix abs() confusion, use fabsf() I've made the mistake of using abs instead of fabs, here is a quick fix. [ Updated to fix both places, and also to use 'fabsf()' which is the proper one that avoids double conversions - not relevant on a real computer, but visible on microcontrollers with hardware support only for 32-bit floats - Linus ] Signed-off-by: Philippe Strauss <catseyechandra@proton.me> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Recent Commits to AudioNoise:main
-
growlingbass: fix abs() confusion, use fabsf()
-
warn about implicit floating point to integer conversions
warn about implicit floating point to integer conversions This got disabled when I had to disable '-Wdouble-promotion' due to it being practically unavoidable with variadic functions. But while '-Wdouble-promotion' wasn't practical, I should have kept '-Wfloat-conversion' around. Yes, it requires a few manual casts for out hacky 'pow()' usage that I'll need to fix for the actual real-time microcontroller case, but those are good to have anyway, not the unavoidable issue with the calling conventions. That makes a couple of bugs in the growlingbass implementation obvious. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>